Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEGAS Pro 15 cannot open openfx-misc (Win64) #66

Open
GlitchyPSIX opened this issue Jul 6, 2019 · 35 comments
Open

VEGAS Pro 15 cannot open openfx-misc (Win64) #66

GlitchyPSIX opened this issue Jul 6, 2019 · 35 comments

Comments

@GlitchyPSIX
Copy link

Loading OFX plugins (Starting video plug-in factory, openfx-misc), VEGAS just crashes with Unhandled Exception (0x0000005), when using the builds from AppVeyor.

@GlitchyPSIX GlitchyPSIX changed the title VEGAS Pro 15 cannot open openfx-misc on VEGAS Pro 15 cannot open openfx-misc (Win64) Jul 6, 2019
@rodlie
Copy link
Contributor

rodlie commented Jul 8, 2019

I can confirm this on Vegas 12 as well (also tested with mingw binaries). Note that it's only Misc.ofx that crashes, CImg.ofx loads fine.

I also tested with Resolve 15 (mingw and your AppVeyor binaries) and everything is fine.

Btw, I think OpenFX broke Vegas support some time ago. The plugins load, the parameters work, but you only get the source image in the viewer, or the render function never runs, I don't know. Can also confirm same behavior in openfx-arena (that at some point in time I used in Vegas 12). Not super important for me, but I though you should know.

@GlitchyPSIX
Copy link
Author

CImg.ofx loads fine, but the preview changes nothing
Loading the binaries included with Natron directly in the OFX folder will load everything but crash VEGAS upon trying to show an effect.

Also, was openfx-arena privated? I can't seem to be able to access it anymore.

Hitfilm works fine in both VEGAS and Natron by the way so something's up...

@devernay
Copy link
Member

devernay commented Jul 8, 2019

You mean "Vegas broke OpenFX support"?

Those crashes are usually tracked down using the ofx Log (which is enabled when compiling plugins in debug mode.

Sometimes (eg with Resolve) the ofx log doesn't work and the only way is to use printf, or to disable the code from the rendering functions (getROD, getROI, render) using #if 0 and then gradually re-enabling it until the crash appears.

Since the crash happens at launch time, my guess is that it's simply that one plugin tries to get a host property which doesn't exist on Vegas, and thus throws an exception. This is easily fixed by setting the second parameter of propGet*() to false. If someone finds out which property is not supported by Vegas, please write it here and I'll document that in https://github.com/NatronGitHub/openfx-misc/blob/master/README-hosts.txt

@devernay
Copy link
Member

devernay commented Jul 8, 2019

It would be nice to have the full host description for Vegas: compile the Rectangle plugin with #define DEBUG_HOSTDESCRIPTION enabled.

For testing purposes, build the plugins separately (make nomulti)

@GlitchyPSIX
Copy link
Author

I'll try, recently went down and installed VC++E 2010 to build with VS as I'm not experienced with building from MinGW/Cygwin

@rodlie
Copy link
Contributor

rodlie commented Jul 8, 2019

I was not referring to the crash when I wrote "OpenFX broke Vegas support". I was talking in general, since no plugins that uses https://github.com/NatronGitHub/openfx seems to do anything in Vegas anymore. They load, the parameters work, but the render action seems to do nothing(?).

@devernay
Copy link
Member

devernay commented Jul 8, 2019

As I wrote before, it's probably simply because of an unsupported property in Vegas. The ofx log helps a lot in this case.

@rodlie
Copy link
Contributor

rodlie commented Jul 8, 2019

sure, I will do it tomorrow (getting late here).

@rodlie
Copy link
Contributor

rodlie commented Jul 8, 2019

Host description for Sony Vegas 12:
https://gist.github.com/rodlie/6ebf8e6d56f3a98e75e1fbca0bc90886

@GlitchyPSIX
Copy link
Author

GlitchyPSIX commented Jul 8, 2019

I may be doing something wrong, but now I can't find the log. (Rectangle -- Compiled with MinGW, crashes upon selecting effect/generator)

@devernay
Copy link
Member

devernay commented Jul 9, 2019

Thanks @rodlie
OpenFX 1.1...
Now do you think you can find the unknown property that causes that exception?
@GlitchyPSIX on my mac, Sony Catalyst Edit puts the OFX log in /Applications.ofxTestLog.txt, so it can be anywhere in the filesystem... Look for a file called "ofxTestLog.txt" after runnin the plugins compiled in debug mode. The next solution is to launch vegas from cmd.sys, and do some printfs in the code. For testing purposes, you should compile each plugin individually. Makefiles do that, but I don't think it's in the VC++ project

@GlitchyPSIX
Copy link
Author

GlitchyPSIX commented Jul 9, 2019

Yeah, the VC++ project doesn't have the option to build separately, so I went with using MinGW-64
I'll run VEGAS from cmd and give you results once I get something
Oh no it appears I'll have some issues seeing the printfs

@devernay
Copy link
Member

You should try with the newest appveyor artifacts. I just fixed a major bug in the openfx Support lib and added more compatibility

@rodlie
Copy link
Contributor

rodlie commented Jul 18, 2019

The plugins are loaded and detected here.

@GlitchyPSIX
Copy link
Author

Loaded and detected, albeit the clicking/render crash issue is still present.

@devernay
Copy link
Member

I don't have VEGAS, so I cannot check here.
What we could do is to be a LOT more permissive with regards to things that the host (Resolve, Fusion, VEGAS, etc) may do wrong. I will work on a version where the checking code is only enabled when compiling in DEBUG mode. This could also be the version included by default with Natron binaries.
So the code will be more fragile because it's still assuming that the host is behaving according to the OpenFX specs, but it will not crash on purpose as soon as it finds something wrong with the host (eg Resolve, Fusion, VEGAS, etc).
And we could distribute two versions as well: the debug version and the dirty version.

@GlitchyPSIX
Copy link
Author

GlitchyPSIX commented Jul 18, 2019

Please contact me directly (personally) check your personal mail, I can directly help with the "not having VEGAS" issue.

@rodlie
Copy link
Contributor

rodlie commented Dec 6, 2019

Btw, I'm able to get (my) plugins working in Vegas 12/14 if I don't check for renderScale in render (if host is com.sonycreativesoftware.vegas).

I skip if (!kSupportsRenderScale && (args.renderScale.x != 1. || args.renderScale.y != 1.)) { and if (srcImg->getRenderScale().x != args.renderScale.x ||...

@devernay
Copy link
Member

devernay commented Dec 6, 2019

could you get the values for args.renderScale and srcImg->getRenderScale()?

@rodlie
Copy link
Contributor

rodlie commented Dec 6, 2019

View Full:
kSupportsRenderScale: 0
renderScale.x: 1
renderScale.y: 1
srcImg->getRenderScale.x: 1
srcImg->getRenderScale.y: 1

View Auto:
kSupportsRenderScale: 0
renderScale.x: 0.25
renderScale.y: 0.25
srcImg->getRenderScale.x: 1
srcImg->getRenderScale.y: 1

View Full:
kSupportsRenderScale: 1
renderScale.x: 1
renderScale.y: 1
srcImg->getRenderScale.x: 1
srcImg->getRenderScale.y: 1

View Auto:
kSupportsRenderScale: 1
renderScale.x: 0.25
renderScale.y: 0.25
srcImg->getRenderScale.x: 1
srcImg->getRenderScale.y: 1

devernay added a commit to NatronGitHub/openfx that referenced this issue Dec 8, 2019
devernay added a commit that referenced this issue Dec 8, 2019
should address #66
@devernay
Copy link
Member

devernay commented Dec 8, 2019

It should be fixed now, can you test?

@rodlie
Copy link
Contributor

rodlie commented Dec 8, 2019

Sure, will take a couple of hours since I don't have access to my Vegas machine at the moment.

@devernay
Copy link
Member

devernay commented Feb 22, 2020

@rodlie can you check if it is fixed, so that we can close this?

@GlitchyPSIX
Copy link
Author

Using the latest AppVeyor builds crash VEGAS upon trying to open an effect still.

@devernay
Copy link
Member

devernay commented Mar 6, 2020

I cannot help much, but maybe @rodlie can have a look

@rodlie
Copy link
Contributor

rodlie commented Mar 7, 2020

I don't have time to look into Vegas issues at the moment, maybe next week. Try building them one by one and check which (plugin) works or not.

Note that some interacts from openfx-supportext has issues in resolve/fusion/vegas. IMHO the OpenFX support in resolve/fusion/vegas is sub-par and requires workarounds to get working properly.

@Dragonslayer293
Copy link

I was redirected here by devernay, I think I may have the same issue. I have the plugins loaded into the ofx folder, but they will not show up in vegas (or resolve/fusion) I am very confused, did vegas mess something up when searching for the plugins?

Screenshot (155)
Screenshot (156)
Screenshot (157)
Screenshot (158)

@rodlie
Copy link
Contributor

rodlie commented May 4, 2020

@Dragonslayer293 You can't use the binary plugins included with Natron in other applications. They require several DLL's only included with Natron. You can however find openfx-misc binaries compatible with other applications here: https://ci.appveyor.com/project/NatronGitHub/openfx-misc/build/artifacts

Note that Vegas support is a hit or miss on some plugins. Most plugins that don't use a overlay/interact should work in Vegas/Resolve/Fusion.

@devernay
Copy link
Member

devernay commented May 7, 2020

Interacts work fine in Resolve on macOS, so I guess they work fine in Fusion too.

@Dragonslayer293
Copy link

@rodlie That was magic, it worked thanks, I have noticed there are some plugins in natron that arent in their. Are those just not compatible with vegas? IE: GLSL In "natron-plugins-master"

those are some of the ones i was hoping could work, if not thats ok though

@devernay
Copy link
Member

@Dragonslayer293 Those are PyPlugs, not OpenFX plugins. You can tray to rebuild these using the Shadertoy plugin, if it works in Vegas, but I doubt it

devernay added a commit to NatronGitHub/openfx that referenced this issue Jun 14, 2020
@devernay
Copy link
Member

It may be fixed see #75
@GlitchyPSIX can you please try with recent artifacts from https://ci.appveyor.com/project/NatronGitHub/openfx-misc/build/artifacts ?
If it's still not working, I'll leave this open, else I'll close it.

@GlitchyPSIX
Copy link
Author

GlitchyPSIX commented Mar 14, 2021

It may be fixed see #75
@GlitchyPSIX can you please try with recent artifacts from https://ci.appveyor.com/project/NatronGitHub/openfx-misc/build/artifacts ?
If it's still not working, I'll leave this open, else I'll close it.

Some things have changed.

  • some Generated Media now displays a preview instead of crashing on sight
    • PlasmaCImg however crashed after clicking on a few of the generated media (without adding it to timeline)
  • some Effects work (Bit of weird controls, but usable, are some of the FX composite modes? They're showing as effects.)
    • CImg effects crash, Absminus crashes, a bunch of other effects crash

@devernay
Copy link
Member

Any hint on the crash reason, like a backtrace for example?

@GlitchyPSIX
Copy link
Author

I can't seem to be able to find any hint in the logs VEGAS presents in the "More Information" log files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants