You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should test and make sure that users of NetSparkleUpdater can use trimming. This will allow users to save file size, but will also fix #394 and #461 by allowing the BouncyCastle dependency to be trimmed (see bcgit/bc-csharp#422), which will drastically reduce the file size of that dependency and allow us to update that dependency to the latest version.
Add <IsTrimmable>true</IsTrimmable> to the applicable csproj files
Add trimming support for the core NetSparkleUpdater library (in a quick test, this generates trim warnings for System.Text.Json. and System.Reflection.Assembly.LoadFile(String), which would need to be fixed)
We should test and make sure that users of
NetSparkleUpdater
can use trimming. This will allow users to save file size, but will also fix #394 and #461 by allowing theBouncyCastle
dependency to be trimmed (see bcgit/bc-csharp#422), which will drastically reduce the file size of that dependency and allow us to update that dependency to the latest version.<IsTrimmable>true</IsTrimmable>
to the applicablecsproj
filesSystem.Reflection.Assembly.LoadFrom()
not being trimmable (https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/incompatibilities#dynamic-assembly-loading-and-execution) — can we work around this somehow? Might be able to use https://github.com/Washi1337/AsmResolver ?NetSparkleUpdater
library (in a quick test, this generates trim warnings forSystem.Text.Json.
andSystem.Reflection.Assembly.LoadFile(String)
, which would need to be fixed)BouncyCastle
/etc. are actually trimmed like we would want for end usersSee also:
The text was updated successfully, but these errors were encountered: