Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to allow users to split heatmap by thread #30

Open
bobrik opened this issue Apr 9, 2018 · 2 comments
Open

option to allow users to split heatmap by thread #30

bobrik opened this issue Apr 9, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@bobrik
Copy link
Contributor

bobrik commented Apr 9, 2018

Currently there seem to be the only mode with seconds on X axis and 20ms buckets on the Y axis.

I'd like to suggest a mode with threads on the Y axis and smaller buckets on the X axis.

My real world usage is ClickHouse. We have loads of data in our instances and they take quite a bit of time to both start up and tear down. During that time we can observe only some low number of cores being saturated.

With the proposed mode we'd be able to see which threads are doing what and when. This mode should work nicely with specialized thread pools.

@spiermar spiermar added enhancement New feature or request review Tagged for review. labels Apr 10, 2018
@brendangregg
Copy link
Contributor

There's a huge benefit at fitting all the data on one screen. We have apps with 1000 threads, and 10,000 threads, and that many rows won't fit. I'd consider such a heat map if it showed "top 100 threads" only for a 100 row heat map -- the current row selector can be used to select how many should be included in the top. The "top" threads will be based on those that have the highest total counts.

Note that this thread visualization would break vertical proximity -- a block in one row may be unrelated to what's happening above or below it. The selection code would also need to support a different type, since it's currently for subsecond offset heat maps.

I'd like to see a prototype and some solved problems.

@spiermar
Copy link
Contributor

Agree with @brendangregg. I see this as a secondary view, that could be triggered by a UI option. This would be specially useful for some mobile OSs where the main thread has a completely different behavior than other threads.

@spiermar spiermar removed the review Tagged for review. label Apr 10, 2018
@spiermar spiermar changed the title Multiple heatmap modes new mode that allows users to split heatmap by thread Apr 10, 2018
@spiermar spiermar changed the title new mode that allows users to split heatmap by thread option to allow users to split heatmap by thread Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants