Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sunburst layout toggle #45

Open
brendangregg opened this issue Apr 16, 2018 · 2 comments
Open

sunburst layout toggle #45

brendangregg opened this issue Apr 16, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@brendangregg
Copy link
Contributor

Similar to #8, this would be an option to draw the flamegraphs in the sunburst layout (radial coordinates).

First use of it I think came from here by @paulirish: https://bugs.chromium.org/p/chromium/issues/detail?id=452624

I've also written about the layout here: http://www.brendangregg.com/blog/2017-02-06/flamegraphs-vs-treemaps-vs-sunburst.html

We can have it as a mode. This is why I wanted flamegraphs to go d3 in the first place, so we can make it more interactive and manipulatable.

@brendangregg brendangregg added the enhancement New feature or request label Apr 16, 2018
@nhick
Copy link
Contributor

nhick commented Apr 17, 2018

Found this recent implementation that might help getting started: https://bl.ocks.org/kerryrodden/7090426
Happy to give it a go later this week unless someone beats me to it.

@paulirish
Copy link

paulirish commented Apr 17, 2018

TBH, I'm much less fond of the sunburst than I used to be.

The general challenge with flamegraphs is focusing their user's attention on the wide&flat parts and ignoring spiky flames. I feel like the sunburst draws attention to the spikes even more than the typical flamegraph layout.

Of course it could always be interesting to toggle to sunburst, but I wouldn't necessarily encourage it these days. :) I think flame and icicle views are the bees knees.

IMO if sunburst were attempted, I think it definitely needs the adjacent tree (like we see in Baobab).

@spiermar spiermar changed the title Sunburst layout toggle sunburst layout toggle Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants