Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for differential flame graphs #57

Closed
spiermar opened this issue Sep 21, 2018 · 4 comments
Closed

support for differential flame graphs #57

spiermar opened this issue Sep 21, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@spiermar
Copy link
Contributor

No description provided.

@spiermar spiermar added the enhancement New feature or request label Sep 21, 2018
@spiermar spiermar self-assigned this Feb 27, 2019
@kebab-mai-haddi
Copy link

@spiermar , can you explain this issue a bit? Or could you redirect me to sources reading which would make me understand?

I want to contribute.

@spiermar
Copy link
Contributor Author

spiermar commented Apr 8, 2019

@avisrivastava254084 already solved in the feat_differential_flame_graphs branch. Just need to run a few tests before merging into master. In a nutshell, the new feature adds support for comparing flame graphs through differential flame graphs. If are looking to start contributing, two issues we are actively looking right now are #69 and #39. Happy to share more details about it.

@mboussaa
Copy link

@spiermar I hit the following error from the feat_differential_flame_graphs branch when running python run.py. Any idea why? Thanks

Traceback (most recent call last):
  File "run.py", line 6, in <module>
    from app import APP
  File "/home/mboussaa/flamescope/app/__init__.py", line 34, in <module>
    from app.views.flame_graph import MOD_FLAME_GRAPH
  File "/home/mboussaa/flamescope/app/views/flame_graph.py", line 21, in <module>
    from app.controllers.flame_graph import generate_flame_graph
  File "/home/mboussaa/flamescope/app/controllers/flame_graph.py", line 25, in <module>
    from app.trace_event.flame_graph import trace_event_generate_flame_graph
  File "/home/mboussaa/flamescope/app/trace_event/flame_graph.py", line 26, in <module>
    from json.decoder import JSONDecodeError
ImportError: cannot import name JSONDecodeError

@spiermar
Copy link
Contributor Author

No need to use the branch anymore. It was already merged into master. And the issue was caused by the python version you are using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants