feat: support for DTrace stack profiles #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- README updated with example DTrace profiling script - heatmap now works as expected - stacks mostly works - need to handle frequency completely
spiermar
changed the title
|
thanks, but I'm probably going to close this PR: there's over a dozen different profilers flamescope can support, and inserting code for each throughout flamescope will be a mess. What flamescope should do is how I've architected flamegraph.pl: have it read a simple generic format, and then we write converters/modules for each. That isolates each profiler to its own file, and doesn't strew code throughout flamescope. At that point it should be even easier to add support for profilers like DTrace. |
|
Closing in favor of #69. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wondering if this could be reviewed/refined and possibly folded in at some point.
Used named regex captures to allow perf, DTrace, and ultimately bcc profiles to be parsed.
Have provided an example DTrace profiling script, but can make it more generic as needed.