Implement subscribeNewHeads,subscriptionReorg,subscribePendingTransactions
#2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirugan
reviewed
Oct 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2211 +/- ##
==========================================
- Coverage 75.63% 75.56% -0.08%
==========================================
Files 104 105 +1
Lines 11102 11344 +242
==========================================
+ Hits 8397 8572 +175
- Misses 2073 2123 +50
- Partials 632 649 +17 ☔ View full report in Codecov by Sentry. |
weiihann
force-pushed
the
weiihann/2205-subscribeNewHeads
branch
2 times, most recently
from
a84cbfd
to
24d8885
Compare
weiihann
changed the title
starknet_subscribeNewHeads and starknet_subscriptionNewHeadsstarknet_subscribeNewHeads
weiihann
force-pushed
the
weiihann/2205-subscribeNewHeads
branch
from
f01671a
to
fcd5e8f
Compare
weiihann
changed the title
starknet_subscribeNewHeadsstarknet_subscribeNewHeads and starknet_subscriptionReorg
weiihann
force-pushed
the
weiihann/2205-subscribeNewHeads
branch
2 times, most recently
from
eaea8ce
to
e7ccc0a
Compare
weiihann
changed the title
starknet_subscribeNewHeads and starknet_subscriptionReorgstarknet_subscribeNewHeads,starknet_subscriptionReorg,starknet_subscribePendingTransactions
weiihann
force-pushed
the
weiihann/2205-subscribeNewHeads
branch
from
e7ccc0a
to
8efccc0
Compare
pnowosie
force-pushed
the
weiihann/2205-subscribeNewHeads
branch
from
8efccc0
to
19641b8
Compare
pnowosie
reviewed
Oct 25, 2024
| EndBlockNum: head.Number, | ||
| } | ||
| } else { // not the first block of the reorg, adjust the starting block | ||
| s.currReorg.StartBlockHash = localHead |
There was a problem hiding this comment.
So we're reverting backwards, so previously set head.Number > currently reverted
There was a problem hiding this comment.
Could you explain further? I didn't get what you meant.
weiihann
changed the title
starknet_subscribeNewHeads,starknet_subscriptionReorg,starknet_subscribePendingTransactionssubscribeNewHeads,subscriptionReorg,subscribePendingTransactions
weiihann
force-pushed
the
weiihann/2205-subscribeNewHeads
branch
from
c680bbf
to
e3b5e9b
Compare
weiihann
force-pushed
the
weiihann/2205-subscribeNewHeads
branch
from
c84636c
to
a4cc367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2205
Fixes #2207
Fixes #2232
The difference between the previous implementation of
juno_subscribeNewHeadsis that it supports streaming historical block headers up to 1024 blocks ago, as per the specification.