Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmarks #2295

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Update benchmarks #2295

merged 5 commits into from
Dec 2, 2024

Conversation

IronGauntlets
Copy link
Contributor

Please view each commit separately.

@IronGauntlets IronGauntlets enabled auto-merge (rebase) November 28, 2024 23:29
@IronGauntlets IronGauntlets force-pushed the IronGauntlets/update-benchmarks branch from 9f1e737 to 594717c Compare November 29, 2024 10:48
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46%. Comparing base (c3170e1) to head (594717c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2295      +/-   ##
==========================================
+ Coverage   75.41%   75.46%   +0.04%     
==========================================
  Files         107      107              
  Lines       11406    11406              
==========================================
+ Hits         8602     8607       +5     
+ Misses       2151     2147       -4     
+ Partials      653      652       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only consern is rename *R -> *Result if possible.
Thanks

@IronGauntlets IronGauntlets merged commit 636ba6d into main Dec 2, 2024
13 checks passed
@IronGauntlets IronGauntlets deleted the IronGauntlets/update-benchmarks branch December 2, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants