-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dev flags for validation of locally built block #7636
Comments
I think we don't need new flags it should just be validated. |
@LukaszRozmej What about cross-version verification? The recent issue probably would be noticed on the very same version but sometimes you may produce block which you think is valid and validation will still prove that - but some regression introduced very recently will (between two versions) will be there and node running old version will notice that. |
Maybe, but less important |
More complex for sure but not to ommit :) First point is mandatory asap to have some sort of validation. |
Block is produced via validation so would be excessive to always do it twice by default? |
We have a possibility to "Simulate" block production for testing purpose.
Issue with that is that we do not validate if built block is valid so we are only checking the "building" part, not if the block could potentially be accepted on chain.
Would be great to have a way to validate blocks:
All names and namespaces are just suggestion - To be adjusted.
The text was updated successfully, but these errors were encountered: