-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Labels to chainspec to activate hardforks at once. #7738
Comments
Can I take care of this issue? |
Sure, first approved PR wins! ;) |
I understood the job can be simplified by adding the label with a timestamp, all good so creating a hashmap and grouping the eips is the solution, considering the exceptions if timestamps conflicts ✅ I would like to take this issue. Also I am part of Dojo Coding community looking to contribute to new open source projects, it would be nice to work with Nethermind project. |
So I think I would add a properties in The only problem is that this would only handle the actual domain logic class, and to parse JSON we would have to duplicate this logic in |
Right now to activate Dencun we need to add to chainspec:
We want to keep fine-grained eip transitions, but we would also like to specify it all at once with some label:
or
It would be great if it worked both ways - so
cancun
flag could be checked, even if single eip timestamps would be set in config. If the activations conflict with each other some exception should be thrown.It should work as that for all forks.
The text was updated successfully, but these errors were encountered: