Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

replaced CairoAssert by FunctionCall #1057

Merged
merged 15 commits into from
Jun 14, 2023
Merged

replaced CairoAssert by FunctionCall #1057

merged 15 commits into from
Jun 14, 2023

Conversation

esdras-santos
Copy link
Contributor

replaced CairoAssert node by FunctionCall.

cicr99
cicr99 suggested changes May 18, 2023
View reviewed changes
src/passes/builtinHandler/require.ts Outdated Show resolved Hide resolved
src/passes/builtinHandler/require.ts Outdated Show resolved Hide resolved
src/utils/astChecking.ts Outdated Show resolved Hide resolved
@cicr99
Comment failing test
0d2e01d 
add some comments
@cicr99 cicr99 requested a review from piwonskp June 8, 2023 21:24
piwonskp
piwonskp approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@piwonskp piwonskp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue of the place where arguments are handled and functions like require are transformed into assert. Apart from that lgtm

@cicr99 cicr99 merged commit 321bfe7 into NethermindEth:cairo-1.0 Jun 14, 2023
@cicr99 cicr99 mentioned this pull request Jun 14, 2023
Closed
@cicr99 cicr99 deleted the replace-CairoAssert-by-FunctionCall branch June 15, 2023 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cicr99 cicr99 cicr99 approved these changes

@piwonskp piwonskp piwonskp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@esdras-santos @piwonskp @cicr99 @esdras-sena