Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing relationships #170

Open
distributive opened this issue Apr 20, 2023 · 1 comment
Open

Missing relationships #170

distributive opened this issue Apr 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@distributive
Copy link
Contributor

distributive commented Apr 20, 2023

I think we would benefit from having:

  • a relationship from cards/printings to their card type (so it can be fetched with an include)
  • a relationship from card/printings to restrictions (ditto)

Also some existing relationships are missing their inverses:

  • card does not have a hasMany relationship back to card_cycle
  • card_cycle, card_set, and card do not have a relationship back to card_pool
  • card does not have a relationship back to card_set
  • printing does not have a relationship back to card_subtype
  • restriction does not have a relationship back to format (I'm not sure if this would be a hasMany or hasOne relationship)
  • card_type does not have a relationship back to printing
  • card and restriction do not have a relationship back to snapshot

I don't know if all/any of these need implementing, but I think this is all of the missing ones.

@plural plural added the enhancement New feature or request label Jun 15, 2024
@plural
Copy link
Contributor

plural commented Jul 21, 2024

Completed already:

  • card to card_cycle
  • card to card_set
  • card_cycle and card_set to card_pool
  • printing to card_subtypes
  • restriction to format
  • card_type to printing

still missing:

  • card and restriction to snapshot
  • card and printing to card pool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants