Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ACLs in Neurodesk Dockerfile Overriding JupyterHub Pre-spawn Hook Permissions #268

Open
wieluk opened this issue Feb 25, 2025 · 2 comments
Assignees

Comments

@wieluk
Copy link

wieluk commented Feb 25, 2025

Hi there,

I've noticed that the Dockerfile for the Neurodesk container sets default ACLs on the home directory on lines 87 and 88:

# Set home directory default acls
RUN chmod g+rwxs /home/${NB_USER}
RUN setfacl -dRm u::rwX,g::rwX,o::0 /home/${NB_USER}

While I understand the intent behind these settings, they are causing issues when I create user directories via a JupyterHub pre-spawn hook. The default ACLs force unwanted permission bits (such as the setgid bit and removing permissions for others) on directories created under /home/${NB_USER}, effectively overwriting the permissions set by my pre-spawn hook.

Do you know any way to prevent this?

Thank you very much for your time and for maintaining such a great project!

@stebo85
Copy link
Contributor

stebo85 commented Feb 25, 2025

@aswinnarayanan ?

@aswinnarayanan
Copy link
Contributor

Might need to consider removing this blanket home dir permission and acl assignment.

I think this was to solve issues with notebooks that were started up without properly configured home dir permissions.
And to handle the saving and restoring of home dir in kubernetes.

Let me have a look through and get back.

@aswinnarayanan aswinnarayanan self-assigned this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

3 participants