Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Simulation tools do not save results to consistent locations #97

Open
jonrkarr opened this issue Nov 24, 2021 · 3 comments
Open
Labels
T: Bug A bug

Comments

@jonrkarr
Copy link

Describe the bug
run_lems_with_jneuroml and run_lems_with_jneuroml_neuron do not save results to consistent locations. The jNeuroML function saves results to exec_in_dir directory. The NEURON function seems to ignore this argument. Navigating this divergence requires extra unexpected work by users.

To Reproduce
Run run_lems_with_jneuroml and run_lems_with_jneuroml_neuron with the same arguments.

Expected behavior
Running run_lems_with_jneuroml and run_lems_with_jneuroml_neuron with the same arguments should produce results in the same location in the same format.

Observed behavior
The functions save results to different directories. This requires the user to be aware of this, use the arguments differently for each tool, and use if statements to manage the use of these methods.

System information:

  • OS: [e.g. iOS]: Ubuntu 20
  • Python version (python --version): 3.9.5
  • Version of tools in use (pynml --help): pyNeuroML 0.5.18

Additional context
Add any other context about the problem here.

@Ragzz1995
Copy link

Hi @jonrkarr ,
I ran both the methods with exec_in_dir="./temp", in both cases as long as the files required for execution was placed inside the ./temp directory, they both produced the same results.

pynml -version : 0.5.20
python 3.6.9

Maybe I can check with specific versions you have mentioned next

@jonrkarr
Copy link
Author

jonrkarr commented Dec 25, 2021

I can try again with 0.5.20 and copy more specific instructions to reproduce the error here

@sanjayankur31
Copy link
Member

I can reproduce this. The issue here is that irrespective of what the exec_in_dir folder is set to, the NEURON scripts are always generated by jnml in the same folder as the LEMS script, and then run there. So, the data etc. is also stored relative to the directory where the LEMS script is run. Making jnml put the generated scripts elsewhere can be done, but it'll require some changes to the logic in jNeuroML.

@sanjayankur31 sanjayankur31 added the T: Bug A bug label Apr 17, 2024
@sanjayankur31 sanjayankur31 transferred this issue from NeuroML/pyNeuroML Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Bug A bug
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants