Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When pushing packets with no frame/timestamp, we should auto generate frame numbers #87

Open
SoylentGraham opened this issue Feb 10, 2024 · 1 comment

Comments

@SoylentGraham
Copy link
Member

SoylentGraham commented Feb 10, 2024

I think I implemented this in one of the decoders (for debugging?) but this should be everywhere.

  • I may have put it in a different high level library
  • Will error if you then start providing data with frames other than 0
  • Need to be careful about un-timed SPS/PPS/Headers
  • Frame numbers dictated by output rather than input
  • We should never ever output a frame with a duplicated frame number unless it IS the same frame (eg. double decode keyframe - or some kinda meta frame - though that should be in the peek meta)
@SoylentGraham SoylentGraham changed the title When pushing packets with no frame/timestamp, we should auto generate frames When pushing packets with no frame/timestamp, we should auto generate frame numbers Feb 10, 2024
@SoylentGraham
Copy link
Member Author

This is currently being done in apple TDecompressorH264 when pushing data into decoompressor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant