Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

올바른 Authentication 적용 및 Theme/Hint 유저 검증 최적화 #25

Open
1 of 3 tasks
delphox60 opened this issue Jul 20, 2023 · 0 comments
Open
1 of 3 tasks

올바른 Authentication 적용 및 Theme/Hint 유저 검증 최적화 #25

delphox60 opened this issue Jul 20, 2023 · 0 comments
Assignees
@delphox60
Labels
🐞bug Something isn't working ♻️refactor Refactor code

Comments

@delphox60
Copy link
Collaborator

delphox60 commented Jul 20, 2023 •
edited
Loading

Issue 타입

  • 버그 수정

이슈 상세 내용

  • AuthenticationPrincipal에서 UserDetails를 전달해주지 못하는 이슈를 발견했습니다.
    • UserDetailsService에서 올바르게 AuthenticationToken을 다루지 않아 생기는 이슈로 보입니다.
  • Theme 및 Hint api 호출 시 유저(shop)를 검증하는 로직의 최적화가 필요합니다.

체크리스트

  • @AuthenticationPrincipal 로 받은 UserDetails 객체가 정상적으로 형성되나요?
  • 테스트(기존 비즈니스 로직)가 모두 정상적으로 실행되나요?
@delphox60 delphox60 added 🐞bug Something isn't working ♻️refactor Refactor code labels Jul 20, 2023
@delphox60 delphox60 self-assigned this Jul 20, 2023
@delphox60 delphox60 mentioned this issue Jul 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delphox60 delphox60

Labels
🐞bug Something isn't working ♻️refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@delphox60