-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat/#18] 영수증 인식 실패 UI 제작 #19
Open
sikkzz
wants to merge
27
commits into
develop
Choose a base branch
from
feat/#18
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
🧷 Storybook: https://6798a432c75b75bf6b81bc26-rrfsigfoff.chromatic.com/ ⏰ Update: 2025년 01월 31일 15시 54분 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 변경사항 & 이슈
영수증 인식 실패 UI 제작
✍️ 관련 설명
UI 제작이라 특별한건 없고 각 뷰마다 배경 관련해서 겹치는 스타일링이 계속 늘어날 거 같은데 이건 이후에 공통화 시킬 예정이야
우선은 전체 페이지 다 만들어 놓고 이후에 리팩토링 하는게 좋을 거 같아
하나 의견이 필요한게 있는데 클래스 네이밍 관련해서 어떻게 하면 좋은지 모르겠어서!
지금은 css-in-js 쓰는거 마냥 했는데 의견 있으면 얘기해줘!
UI 페이지는 /recognition-fail 에서 확인 가능한데 url도 내 마음대로 정한거라 의견 있으면 부탁해!
⭐️ Review point
📷 Demo