Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the need to include glider-compat.min.js is not clearly mentioned in documentation #118

Open
JackieHayduk opened this issue Aug 11, 2020 · 6 comments · May be fixed by #164
Open

the need to include glider-compat.min.js is not clearly mentioned in documentation #118

JackieHayduk opened this issue Aug 11, 2020 · 6 comments · May be fixed by #164
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@JackieHayduk
Copy link

The documentation could use a more clear direction around the compatibility file needing to be included. I was debugging an IE11 issue and was originally thinking our version of your plugin was out of date and then I stumbled across the now closed issue that this file was not in the repo. By including it my IE issue was resolved. I would add a note about browser compatibility in your getting started info for future users.
@gobaSportsGroup
Copy link

Hey @JackieHayduk can you share with me how you resolved the IE11 issue?

@JackieHayduk
Copy link
Author

@gobaSportsGroup In the file directory there is a file called glider-compat.min.js which isn't included by default. If importing the plugin at the top of a js file as such:
import Glider from 'glider-js';

you have to also include an import to the compat file specifically for me the path was this:
import '../../../../../node_modules/glider-js/glider-compat.min.js';

so my complete import for this plugin is:
import Glider from 'glider-js'; import '../../../../../node_modules/glider-js/glider-compat.min.js';

Hope this helps!

@NickPiscitelli
Copy link
Owner

The compatibility file is documented on the README in the repository, but it is indeed missing from the documentation.

@NickPiscitelli NickPiscitelli added enhancement New feature or request good first issue Good for newcomers labels Sep 28, 2020
@simplenotezy simplenotezy mentioned this issue Oct 28, 2020
Open
@sardug10
Copy link

sardug10 commented Feb 2, 2021

Hey, if this issue is still open, can I work on it?

@sardug10 sardug10 mentioned this issue Feb 3, 2021
Closed
@NickPiscitelli
Copy link
Owner

NickPiscitelli commented Feb 8, 2021 via email

@sardug10 sardug10 linked a pull request Feb 8, 2021 that will close this issue
Open
@NickPiscitelli
Copy link
Owner

Sorry for the late reply.

After further review of this issue, both the documentation and the README already mention this compatibility file in the browser support section. I'm not sure if calling any extra attention to this file is warranted, but if so, it should be listed as a footnote and not as a step of the install process. Ultimately, few users will need this file since market share for legacy browsers is quite insignificant as of late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
4 participants
@NickPiscitelli @gobaSportsGroup @sardug10 @JackieHayduk