This repository has been archived by the owner on Jul 8, 2024. It is now read-only.
Improved handling of ServiceWorkers and their events #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nickersoft
force-pushed
the
improved-sw-events
branch
from
66520fe
to
0858ff6
Compare
Nickersoft
force-pushed
the
improved-sw-events
branch
from
0858ff6
to
4b48028
Compare
Nickersoft
added a commit
that referenced
this pull request
Oct 19, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a long withstanding issue in which calling events on notifications created by ServiceWorkers would result in console errors. This update adds separate event handling for SW notifications to prevent these kind of errors from occurring. That said, only click() and close() event handlers will work on SW notifications.
This fix also adds some new options for SW notifications such as "data" and "icon", as per request in issue #70.
See issues #68, #69, and #70 for more info