Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

[GNB] Reign combo not proccing consistently on any setting #1849

Open
PaladinPrincess opened this issue Nov 2, 2024 · 4 comments
Open

[GNB] Reign combo not proccing consistently on any setting #1849

PaladinPrincess opened this issue Nov 2, 2024 · 4 comments

Comments

@PaladinPrincess
Copy link

I've been activating and deactivating alot of different skills on the main, aoe, and burst strike combos, but the Reign combo is almost never proccing correctly. I've turned off skill switch on Bloodfest, and activated as many buffs as I can to use it, but it seems to not activate no matter what I do.

@Akechi-kun
Copy link
Contributor

Akechi-kun commented Nov 4, 2024

I will need some more information, as I cannot replicate this & so far you are the only one to report this. If you can, please post the following:

  • screenshot of all settings for GNB (or your debug)
  • more in-depth explanation (boss or trash? what version are you on? overworld or instance? mid fight, end of fight, or always?)
  • clip (dummy works)

I would ask for debug file but a screenshot of your settings will suffice.

@PaladinPrincess
Copy link
Author

I did manage to do more testing, but it seems the combo can only be started immediately after you use Double Down, but DD is not a requirement for the skill to be used. So the Ready to Reign is wasted if DD is on cooldown. Reign Combo is toggled on for both Burst Strike and Main combo options. Now granted, it seems it PREFERS to only be used if every burst option is used up, but things can go out of sync pretty quick.

  • Details you asked: All Overworld areas / Any instance of suitable level
  • Boss and Trash
  • Version is up to date for all plugin requirements
  • Throughout any fight

The clip given will show the full burst window and show that it only comes up after double down is used. Buffs are to the far right. Hopefully this helps, I'm kinda new to this and havent slept well so sorry for any mistakes

2024-11-0601-17-31-ezgif.com-resize-video.mp4

@Akechi-kun
Copy link
Contributor

Akechi-kun commented Nov 7, 2024

it seems the combo can only be started immediately after you use Double Down, but DD is not a requirement for the skill to be used

This is indeed the case on how it's coded due to how each burst should align.
Each burst consists of 8 GCDs in a specific order dependent on how you are entering No Mercy;
can be 3 scenarios:

  • 2 cartridges, without Bloodfest (1 minute window)
  • 3 cartridges, without Bloodfest (1 minute window)
  • 2 cartridges, with Bloodfest (2 minute window)

image

also, you want to keep them in this same order that they're used as best you can to ensure you do not delay any important GCDs throughout the fight outside of your own buff, since this job is rather airtight on when to cast certain skills optimally. You should always be using Double Down before your Reign combo anyways, so there's no need to constitute a change here.

I recently pushed a PR for some protection that will ensure these skills are used, regardless of user error or scuffed windows. I believe that can help mitigate your personal issue here since the PR itself helps remedy the rather tight conditions that are already set on these skills.

@PaladinPrincess
Copy link
Author

Aaaah I see I see, thank you very much! Yeah scuffed timing is a hard thing to avoid bweh ;w; Thanks so much for helping me through it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants