Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Box CSV Reader applies wrong data type #144

Closed
louis-paulvlx opened this issue Dec 12, 2024 · 0 comments · Fixed by #145 or #147
Closed

[BUG] Box CSV Reader applies wrong data type #144

louis-paulvlx opened this issue Dec 12, 2024 · 0 comments · Fixed by #145 or #147
Labels
bug Something isn't working

Comments

@louis-paulvlx
Copy link
Contributor

Concerns Box integration.

With the previous version (0.8x) the data type inside the csv was automatically detected by the csv_reader.
Now, the new behaviour is forcing transformation of some date fields as str.

@louis-paulvlx louis-paulvlx added the bug Something isn't working label Dec 12, 2024
@dannymeijer dannymeijer linked a pull request Dec 12, 2024 that will close this issue
dannymeijer pushed a commit that referenced this issue Dec 17, 2024
Fix bug on csvreader for box integration where all types were cast to String.
@dannymeijer dannymeijer linked a pull request Dec 17, 2024 that will close this issue
9 tasks
dannymeijer added a commit that referenced this issue Dec 17, 2024
Fix bug on csvreader for box integration where all types were cast to String.

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the **CONTRIBUTING** document.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.

---------

Co-authored-by: louis-paulvlx <[email protected]>
Co-authored-by: Danny Meijer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant