Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple email recipients #113

Conversation

kumarabhishekpandey
Copy link
Contributor

Support multiple email recipients

Description

In current version of SE, email recipient get_to_mail is expected to be a single email address.
The change ensures that if get_to_mail contains multiple email addresses separated by commas, they are split into a list of individual email addresses before being passed to the sendmail function. This is necessary because sendmail expects a list of recipient addresses.

Related Issue

112

Motivation and Context

How Has This Been Tested?

Uploaded wheel file generated to Databricks cluster ran spark expectations job.

Screenshots (if appropriate):

se_test_cases

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@asingamaneni asingamaneni self-requested a review November 8, 2024 01:15
Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni merged commit f467a78 into Nike-Inc:main Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants