Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md #55

Open
ukorvl opened this issue Jun 27, 2024 · 1 comment · May be fixed by #117
Open

Add CONTRIBUTING.md #55

ukorvl opened this issue Jun 27, 2024 · 1 comment · May be fixed by #117
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@ukorvl
Copy link
Member

ukorvl commented Jun 27, 2024

We need to provide some standard for developers how to make feature requests, report bugs and contribute to the reposiotry.
We already have https://github.com/NilFoundation/nil.js/blob/6454208fe8665ec40c342dca6eb1baa3ef10ede7/.github/CONTRIBUTING.md but there is only a description of how to work with changesets. What should be added as well:

  • Description of how to setup repository to start development
  • Naming conventions
  • How to setup tests and how to test your code with real cluster interaction
  • Maybe we should move CONTRIBUTING.md to the root of the repository, it looks like a common practice.
@ukorvl ukorvl added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jun 27, 2024
@starc007 starc007 linked a pull request Nov 18, 2024 that will close this issue
@starc007
Copy link

Hey @ukorvl
I've created PR #117 that addresses all the requested improvements to our contribution guidelines:

  • ✅ Moved CONTRIBUTING.md to the root directory for better visibility
  • ✅ Added comprehensive setup instructions for local development
  • ✅ Documented naming conventions based on our current codebase patterns
  • ✅ Added detailed testing guidelines, including local cluster setup
  • ✅ Included clear workflow for issues and PRs
  • ✅ Updated README.md with a new contributing section

Please review the changes and let me know if anything needs adjustment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants