Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't disable services.gnome.gnome-keyring to replace it with home manager services.pass-secret-service #201766

Closed
BenediktBroich opened this issue Nov 18, 2022 · 2 comments
Labels
0.kind: bug Something is broken

Comments

@BenediktBroich
Copy link
Contributor

BenediktBroich commented Nov 18, 2022

Describe the bug

Can't disable services.gnome.gnome-keyring.enable = false; to replace it with services.passSecretService.enable= true; or home manager services.pass-secret-service.enable= true; when services.xserver.desktopManager.gnome.enable = true; is enabled.

But i get following error.

error: The option `services.gnome.gnome-keyring.enable' has conflicting definition values:
       - In `/nix/store/fkx24s5smqs2xw88n7yx3xy2jk1gx80l-source/profiles/gnome': false
       - In `/nix/store/da9dyx30lsdgw2x2gnxkc88aq1d9fwik-source/nixos/modules/services/x11/desktop-managers/gnome.nix': true

Steps To Reproduce

configuration.nix

services = {
    xserver = {
      enable = true;
      displayManager.gdm.enable = true;
      desktopManager.gnome.enable = true;
    };
    gnome.gnome-keyring.enable = false;
    # passSecretService.enable = true;
  };
}

Home Manager

services.pass-secret-service.enable = true;

Expected behavior

I should be able to disable gnome.gnome-keyring.enable. Or maybe there should be an option to override org.freedesktop.secrets.service Exec as described in this Issue.?

Screenshots

Additional context

Last patch

Source

Issue insights

Related Issues

Notify maintainers

Pass Secret Service Maintainer
@aidalgol you are the maintainer of services.passSecretService so maybe you have some insights.

Gnome Maintainers
@bobby285271 @hedning @jtojnar @dasj19 @maxeaubrey

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

 - system: `"x86_64-linux"`
 - host os: `Linux 6.0.6, NixOS, 22.05 (Quokka), 22.05.20221105.f09ad46`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.9.1`
 - channels(root): `"nixos-22.11pre425577.0533be43f1c"`
 - channels(user): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Thanks for you help!

@BenediktBroich BenediktBroich added the 0.kind: bug Something is broken label Nov 18, 2022
@BenediktBroich BenediktBroich changed the title Can't disable services.gnome.gnome-keyring to replace it with services.pass-secret-service Can't disable services.gnome.gnome-keyring to replace it with home manager services.pass-secret-service Nov 18, 2022
@jtojnar
Copy link
Member

jtojnar commented Nov 18, 2022

You can use lib.mkForce to override the option. I think we did not make the gnome-keyring option just enabled by default because we were not sure if something won’t seriously break without the service.

@BenediktBroich
Copy link
Contributor Author

BenediktBroich commented Nov 18, 2022

Thanks. That did work. Here is my full configuration if someone else is searching for this.

configuration.nix

  services = {
    xserver = {
      enable = true;
      displayManager.gdm.enable = true;
      desktopManager.gnome.enable = true;
    };
    gnome.gnome-keyring = pkgs.lib.mkForce { enable = false; };
  };

home-manager

  services.pass-secret-service.enable = true;
  programs = {
    password-store = {
      enable = true;
      settings = {
        PASSWORD_STORE_DIR = ".password-store"; # pypass will search for this folder in your home directory DON'T ADD ~/
      };
    };
  };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

No branches or pull requests

2 participants