Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mastodon: migrate to prefetch-yarn-deps #269295

Merged
merged 1 commit into from
Nov 23, 2023
Merged

mastodon: migrate to prefetch-yarn-deps #269295

merged 1 commit into from
Nov 23, 2023

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Nov 22, 2023 •
edited
Loading

Description of changes

#240174

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey mentioned this pull request Nov 22, 2023
Closed
39 tasks
@Stunkymonkey Stunkymonkey force-pushed the mastodon-migrate-prefetch-yarn-deps branch from 5716d7c to 5559eb2 Compare November 22, 2023 21:57
@ofborg ofborg bot requested review from erictapen, Izorkin and ghuntley November 23, 2023 01:49
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 23, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 23, 2023
@erictapen erictapen merged commit f880f6b into NixOS:master Nov 23, 2023
@Stunkymonkey Stunkymonkey deleted the mastodon-migrate-prefetch-yarn-deps branch November 25, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Izorkin Izorkin Izorkin approved these changes

@erictapen erictapen Awaiting requested review from erictapen

@ghuntley ghuntley Awaiting requested review from ghuntley

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stunkymonkey @Izorkin @delroth @erictapen