Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-fiddle: migrate to prefetch-yarn-deps #269302

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Nov 22, 2023

Description of changes

#240174

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey force-pushed the electron-fiddle-migrate-prefetch-yarn-deps branch from 56c97f5 to c1677a5 Compare March 25, 2024 22:00
@Stunkymonkey
Copy link
Contributor Author

Stunkymonkey commented Mar 25, 2024

Result of nixpkgs-review pr 269302 run on x86_64-linux 1

1 package built:
  • electron-fiddle

EDIT: only builds with NIXPKGS_ALLOW_INSECURE=1 nixpkgs-review pr 269302

@ofborg ofborg bot requested a review from andersk March 25, 2024 23:06
@Stunkymonkey Stunkymonkey merged commit d50918b into NixOS:master Mar 26, 2024
25 checks passed
@Stunkymonkey Stunkymonkey deleted the electron-fiddle-migrate-prefetch-yarn-deps branch March 26, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants