gphoto2: Add option for group name #296832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
l0b0
force-pushed
the
gphoto2-group-name-config
branch
from
eafb193
to
e1942fe
Compare
bjornfor
reviewed
Mar 19, 2024
l0b0
force-pushed
the
gphoto2-group-name-config
branch
from
e1942fe
to
9f87ab8
Compare
bjornfor
reviewed
Mar 22, 2024
|
|
||
| let | ||
| inherit (nixos {}) config; | ||
| group = config.programs.gphoto2.group; |
There was a problem hiding this comment.
Won't this reference the default value and not the one from the users' nixos config? Maybe it's better to make the option read-only (I think that's possible), so that at least the magic string goes away?
l0b0
force-pushed
the
gphoto2-group-name-config
branch
from
9f87ab8
to
702e47d
Compare
l0b0
force-pushed
the
gphoto2-group-name-config
branch
2 times, most recently
from
3e7f813
to
9cb19fb
Compare
SuperSandro2000
requested changes
Apr 28, 2024
Comment on lines
19
to
20
| inherit (nixos {}) options; | ||
| group = options.programs.gphoto2.group.value; |
There was a problem hiding this comment.
I am pretty sure that this won't work on none nixos systems. We should probably just make this a string.
There was a problem hiding this comment.
How's the current solution?
wegank
added
the
2.status: merge conflict
l0b0
force-pushed
the
gphoto2-group-name-config
branch
from
9cb19fb
to
f833ab8
Compare
ofborg
bot
removed
the
2.status: merge conflict
wegank
added
the
2.status: merge conflict
l0b0
force-pushed
the
gphoto2-group-name-config
branch
from
f833ab8
to
bed1cc2
Compare
Enables referencing it in configuration dynamically, rather than with a magic string. Closes NixOS#294871.
l0b0
force-pushed
the
gphoto2-group-name-config
branch
from
bed1cc2
to
c3ee634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Enables referencing it in configuration dynamically, rather than with a magic string.
Closes #294871.
To do:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.