Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.doctest-ignore-unicode: drop #313169

Merged
merged 1 commit into from
May 20, 2024

Conversation

patka-123
Copy link
Contributor

@patka-123 patka-123 commented May 20, 2024

Description of changes

part of #311054

Has not had a new release for 11 years.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@patka-123 patka-123 force-pushed the doctest-ignore-unicode-drop branch from 789bdf5 to b087411 Compare May 20, 2024 16:18
pkgs/top-level/python-aliases.nix Outdated Show resolved Hide resolved
@patka-123 patka-123 force-pushed the doctest-ignore-unicode-drop branch from b087411 to a9fd32b Compare May 20, 2024 17:02
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 20, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 20, 2024
@cole-h
Copy link
Member

cole-h commented May 20, 2024

@ofborg eval

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit e804778 into NixOS:master May 20, 2024
23 checks passed
@patka-123 patka-123 deleted the doctest-ignore-unicode-drop branch May 21, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants