Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.{cov-core,nose-cov,dyn,pylti}: drop #313182

Closed
wants to merge 1 commit into from

Conversation

patka-123
Copy link
Contributor

@patka-123 patka-123 commented May 20, 2024

Description of changes

part of #311054

Both packages haven't been maintained since > 10 years.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@RaghavSood
Copy link
Member

There appear to be some side effects.

There's an alias for covCore here.

cov-core is also an input to python3Package.dyn and python3Packages.pylti

@patka-123 patka-123 force-pushed the cov-core-nose-cov-drop branch from 973d7f3 to 8e72157 Compare May 20, 2024 17:31
@patka-123 patka-123 marked this pull request as draft May 20, 2024 17:32
@patka-123 patka-123 marked this pull request as draft May 20, 2024 17:32
@patka-123 patka-123 force-pushed the cov-core-nose-cov-drop branch from 8e72157 to 2c86848 Compare May 20, 2024 17:49
@patka-123 patka-123 changed the title python311Packages.{cov-core,nose-cov}: drop python311Packages.{cov-core,nose-cov,dyn,pylti}: drop May 20, 2024
@patka-123 patka-123 force-pushed the cov-core-nose-cov-drop branch 3 times, most recently from 83f3497 to 9547572 Compare May 20, 2024 17:54
@patka-123 patka-123 marked this pull request as ready for review May 20, 2024 17:55
@patka-123
Copy link
Contributor Author

There appear to be some side effects.

There's an alias for covCore here.

cov-core is also an input to python3Package.dyn and python3Packages.pylti

Oops. Those packages have also been removed since they were old and unmaintained. Can you have a look again?

@cole-h
Copy link
Member

cole-h commented May 20, 2024

@ofborg eval

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 20, 2024
@patka-123 patka-123 force-pushed the cov-core-nose-cov-drop branch 3 times, most recently from a08ea48 to 0e446d0 Compare May 21, 2024 10:33
@patka-123 patka-123 force-pushed the cov-core-nose-cov-drop branch from 0e446d0 to a944737 Compare May 21, 2024 10:35
@patka-123 patka-123 requested a review from natsukium May 21, 2024 10:39
@@ -142,6 +143,7 @@ mapAliases ({
doctest-ignore-unicode = throw "doctest-ignore-unicode has been removed since it has been unmaintained for 11 years"; # added 2024-05-20
dogpile_cache = dogpile-cache; # added 2021-10-28
dogpile-core = throw "dogpile-core is no longer maintained, use dogpile-cache instead"; # added 2021-11-20
dyn = throw "dyn has been removed because it is no longer maintained"; # added 2024-05-20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this package, but it doesn't seem to be unmaintained since the last release was a year ago.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhhh, you are right... I have no idea where I looked at then. Must've checkex the wrong one. I'll unfortunately have to cloae this PR since I don't have time to fix it :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

@patka-123 patka-123 closed this May 21, 2024
@patka-123 patka-123 deleted the cov-core-nose-cov-drop branch May 21, 2024 17:12
@fabaff fabaff mentioned this pull request May 21, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants