Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.dyn: refactor #313476

Merged
merged 5 commits into from
May 22, 2024
Merged

python312Packages.dyn: refactor #313476

merged 5 commits into from
May 22, 2024

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 21, 2024

Description of changes

Successor of #313182

Part of #311054

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

fabaff added 3 commits May 21, 2024 23:04
It was archived and unmaintained since 2014
pylti has been removed because it is unmaintained since 2019
It was archived and unmaintained since 2012
@fabaff
Copy link
Member Author

fabaff commented May 21, 2024

Result of nixpkgs-review pr 313476 run on x86_64-linux 1

4 packages built:
  • python311Packages.dyn
  • python311Packages.dyn.dist
  • python312Packages.dyn
  • python312Packages.dyn.dist

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natsukium natsukium merged commit 2ec1d18 into NixOS:master May 22, 2024
26 of 27 checks passed
@fabaff fabaff deleted the dyn-refactor branch May 22, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants