insulator2: 2.12.2 -> 2.13.2 #323882
insulator2: 2.12.2 -> 2.13.2 #323882
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
Stunkymonkey
force-pushed
the
insulator2-migrate-fixup-yarn-lock
branch
2 times, most recently
from
ea54cda
to
beac072
Compare
|
|
|
@getchoo what do you think about the current changes? (i know the commits are not nicely done yet.) |
Stunkymonkey
force-pushed
the
insulator2-migrate-fixup-yarn-lock
branch
from
9bcf28d
to
ea31168
Compare
| # see: https://github.com/andrewinci/insulator2/pull/733 | ||
| (fetchpatch { | ||
| name = "fix-rust-1.80.0"; | ||
| url = "https://github.com/andrewinci/insulator2/commit/7dbff0777c4364eec68cf90488d99f06b11dfa98.patch"; | ||
| hash = "sha256-P8rBufYpREP5tOO9vSymvms4f2JbsUEjK7/yn9P7gYk="; | ||
| }) |
There was a problem hiding this comment.
I'd prefer we wait for this to have an actual in-tree commit, or just vendor it here
There was a problem hiding this comment.
i submitted one week ago: andrewinci/insulator2#733
i guess this will take much time...
There was a problem hiding this comment.
I'd recommend vendoring the patch here then. It's just more reliable than a commit from a fork
There was a problem hiding this comment.
this is already the official repo... the fork would be https://github.com/Stunkymonkey/insulator2
There was a problem hiding this comment.
Commit from a GitHub PR isn't guaranteed to be stable. Upstream author may require you to do a force push which may break the visibility of this commit hash. Thus it would be better to add a patch in this repo instead.
And since you already have Cargo.lock here, you can patch Cargo.toml only, and copy Cargo.lock
Stunkymonkey
force-pushed
the
insulator2-migrate-fixup-yarn-lock
branch
from
ea31168
to
35c788f
Compare
Stunkymonkey
requested review from
getchoo,
philiptaron,
SuperSandro2000 and
lilyinstarlight
Aleksanaa
changed the title
|
ping at reviewers |
Stunkymonkey
force-pushed
the
insulator2-migrate-fixup-yarn-lock
branch
from
35c788f
to
817fd89
Compare
Description of changes
part of #240174
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.