Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetrio-desktop: migrate to fixup-yarn-lock #323884

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Jul 1, 2024

Description of changes

part of #240174

nix-build . -A tetrio-desktop

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 1, 2024
@Stunkymonkey Stunkymonkey marked this pull request as ready for review August 13, 2024 21:29
@Stunkymonkey Stunkymonkey force-pushed the tetrio-desktop-frontend-fixup-fixup-yarn-lock branch from ad6629c to 68fc74c Compare August 13, 2024 21:31
@huantianad
Copy link
Contributor

I'm curious, for our needs we only actually need the resulting node_modules folder that we would get after installing the package's yarn.lock/package.json. Is there a more ergonomic way to get that? Otherwise, looks good.

@Stunkymonkey Stunkymonkey merged commit 83132a9 into NixOS:master Aug 15, 2024
25 checks passed
@Stunkymonkey Stunkymonkey deleted the tetrio-desktop-frontend-fixup-fixup-yarn-lock branch August 15, 2024 16:25
@Stunkymonkey
Copy link
Contributor Author

@huantianad sorry no better idea.

@huantianad
Copy link
Contributor

@Stunkymonkey all good, i was just wondering if there was a convenient function that provided the pre-installed node_modules, but all good if there isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants