Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.python-hglib: 2.6.2 -> 2.6.2-unstable-2024-06-17 #325681

Closed
wants to merge 1 commit into from
Closed

python3Packages.python-hglib: 2.6.2 -> 2.6.2-unstable-2024-06-17 #325681

wants to merge 1 commit into from

Conversation

ijaketak
Copy link
Contributor

@ijaketak ijaketak commented Jul 9, 2024

Description of changes

Fixes #311054.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@applePrincess
Copy link
Contributor

Result of nixpkgs-review pr 325681 run on x86_64-linux 1

2 packages failed to build:
  • mozphab
  • mozphab.dist
8 packages built:
  • python311Packages.powerline
  • python311Packages.powerline.dist
  • python311Packages.python-hglib
  • python311Packages.python-hglib.dist
  • python312Packages.python-hglib
  • python312Packages.python-hglib.dist
  • sourcehut.hgsrht
  • sourcehut.hgsrht.dist

@applePrincess
Copy link
Contributor

Looks good to me. two packages failing is due to python3Packages.glean-sdk failed to build.
just squash two commits into one

python3Packages.python-hglib: 2.6.2 -> 2.6.2-unstable-2024-06-17

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 11, 2024
@ijaketak ijaketak changed the title python3Packages.python-hglib: Bump up to 2.6.2+nixpkgs.1 by upstream python3Packages.python-hglib: 2.6.2 -> 2.6.2-unstable-2024-06-17 Jul 11, 2024
@ijaketak
Copy link
Contributor Author

Closed in favor of #330739.

@ijaketak ijaketak closed this Aug 14, 2024
@ijaketak ijaketak deleted the ijaketak-python-hglib branch September 7, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate python packages from nose to pynose
3 participants