-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from qt4 to qt5 [WIP] #33239
Conversation
I would like to take on some Qt4 apps too. List of files mentioning Qt4: [truncated, moved to #33248] |
223 total. I think we already have Qt5 version of VLC in
LibreOffice will probably land Qt5 in February: https://www.phoronix.com/scan.php?page=news_item&px=LibreOffice-VCL-Qt5 |
It is fine to build applications that support Qt 5 with Qt 5, but is there any reason to stop building applications with Qt 4 that don't (e.g. i7z)? Qt 4 works well and is not going to be removed in any near future. |
@yegortimoshenko Wouldnt it be better to create a tracking issue with that list? I doubt that all of those packages will be handled by this PR. @orivej I agree with you. I think it may be worth revisiting that question once there are only a few packages depending on Qt4 but for now I don't see any reason to drop Qt4 from packages not supporting Qt5. |
@peterhoeg The fork of qjoypad that you have found is pretty good, but its UI is a bit deficient compared to its qt4 ancestor. I'd like these pull requests to be merged before we switch: panzi/qjoypad#17 and panzi/qjoypad#18. |
Sounds reasonable for |
@orivej:
But in other cases, patching application to support Qt5 is preferable. |
@yegortimoshenko Works fine for me. |
Works for me too. It must be run as root, but when it isn't it doesn't segfault, it prints:
|
Interesting, |
Also move from qt4 -> qt5
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/bump-openmw-0-44-0-and-ported-to-qt5/2121/1 |
Are there any updates on this pull request, please? |
No longer relevant. |
Motivation for this change
Qt4 is deprecated.
Mixxx can simply be recompiled for Qt5.
OpenMW is also updated from 0.42.0 to 0.43.0 with a slightly newer openscenegraph.
Vanilla openscenegraph is updated from 3.4.0 -> 3.4.1
If you guys think they should be split up into multiple different PRs for the sake of not changing too many things at the same time, let me know.
Cc: @abbradar @aszlig @cillianderoiste @7c6f434c
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)