emacsPackages: clean the bulk-updating scripts #351056
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: clean-up
8.has: package (new)
jian-lin
requested changes
Oct 25, 2024
There was a problem hiding this comment.
It would be good to put this doc into Nixpkgs manual. https://nixos.org/manual/nixpkgs/unstable/#chap-language-support is a good place.
There was a problem hiding this comment.
What is motivation of factoring out this lib-update-scripts.sh? It has only one consumer and factoring out it adds complexity like SOURCE and DIR.
There was a problem hiding this comment.
I am cogitating to split the functions here so that they could be loaded via source lib-update-scripts.sh and so be executed interactively.
E.g. the function that tests the package set can be run whether the set was generated locally or downloaded from the overlay.
There was a problem hiding this comment.
Sounds good. What about adding that to the doc?
There was a problem hiding this comment.
I have documented it.
pkgs/applications/editors/emacs/elisp-packages/lib-update-scripts.sh
Outdated
Show resolved
Hide resolved
pkgs/applications/editors/emacs/elisp-packages/elpa-devel-generated.nix
Outdated
Show resolved
Hide resolved
AndersonTorres
force-pushed
the
elisp
branch
5 times, most recently
from
9cae614 to
af1a662
Compare
ofborg
bot
added
10.rebuild-darwin: 0
AndersonTorres
force-pushed
the
elisp
branch
7 times, most recently
from
e110470 to
6539e9f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
13 tasks
github-actions
bot
removed
the
8.has: documentation
AndersonTorres
changed the title
|
@jian-lin now it is ready. I did the following modifications
|
ofborg
bot
added
10.rebuild-linux: 0
AndersonTorres
force-pushed
the
elisp
branch
from
d755534 to
fabe1cc
Compare
The tasks executed by the update-from-overlay script are very useful for interactive as well as batch update sessions. Thinking about it, I refactored the whole thing: - The tasks are now functions kept in a file, `update-scripts-library.sh`. This file is meant to be sourced, so that the functions can be used in both batch and interactive environments. - The update-from-overlay script was rewritten accordingly.
They are identical except for the parameters they use. Let's merge them in a single script. Now they can be called via `./update-package-sets <package sets>`.
They will be gathered in a more fitting documentation.
github-actions
bot
added
the
8.has: documentation
13 tasks
|
Drafted |
github-actions
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.