Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avalanchego: 1.11.11 -> 1.12.0-initial-poc.6 #351441

Merged
merged 3 commits into from
Nov 7, 2024
Merged

avalanchego: 1.11.11 -> 1.12.0-initial-poc.6 #351441

merged 3 commits into from
Nov 7, 2024

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Oct 26, 2024 •
edited
Loading

Things done

ZHF: #352882

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from urandom2 and qjoly October 26, 2024 16:19
@Bot-wxt1221 Bot-wxt1221 added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2024
khaneliman
khaneliman reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to specify the default sdk frameworks anymore, so we can remove those references.

pkgs/by-name/av/avalanchego/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/av/avalanchego/package.nix Outdated Show resolved Hide resolved
@Bot-wxt1221
Copy link
Member Author

@khaneliman Done.

khaneliman
khaneliman approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@khaneliman khaneliman merged commit 3aea494 into NixOS:master Nov 7, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaneliman khaneliman khaneliman approved these changes

@urandom2 urandom2 Awaiting requested review from urandom2

@qjoly qjoly Awaiting requested review from qjoly

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bot-wxt1221 @khaneliman