Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Haskell-Nix bindings, hercules-ci-agent, cachix nix library version #357224

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 19, 2024

Description

Prerequisite for

Things done

Will merge master into haskell-updates when merged.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @domenkozar

Add a 👍 reaction to pull requests you find important.

@roberth roberth added the backport release-24.11 Backport PR automatically label Nov 19, 2024
@roberth
Copy link
Member Author

roberth commented Nov 25, 2024

I'd like to merge this asap, as otherwise hci and cachix will be on unsupported versions of Nix for the release.

Copy link
Member

@maralorn maralorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought just the other day that something like haskell-packages by name would be awesome. Not sure if this design is the sweet spot but we can always improve on it later.

@tomberek tomberek self-assigned this Nov 25, 2024
@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 357224 run on x86_64-linux 1

16 packages built:
  • cachix (cachix.bin ,cachix.doc ,haskellPackages.cachix.bin)
  • devenv
  • haskellPackages.cachix
  • haskellPackages.cachix.doc
  • haskellPackages.hercules-ci-agent
  • haskellPackages.hercules-ci-agent.doc
  • haskellPackages.hercules-ci-cli
  • haskellPackages.hercules-ci-cli.doc
  • haskellPackages.hercules-ci-cnix-expr
  • haskellPackages.hercules-ci-cnix-expr.doc
  • haskellPackages.hercules-ci-cnix-store
  • haskellPackages.hercules-ci-cnix-store.doc
  • hci
  • hercules-ci-agent
  • tests.haskell.cabalSdist.hercules-ci-cnix-store
  • tests.haskell.cabalSdist.hercules-ci-cnix-store.doc

@tomberek tomberek merged commit 2de990d into NixOS:master Nov 25, 2024
34 of 35 checks passed
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants