-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qbittorrent: 5.0.1 -> 5.0.2; move to by-name; modernize derivation #358115
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove non-default apple SDK input, and use the default one.
See https://github.com/NixOS/nixpkgs/blob/master/doc/stdenv/platform-notes.chapter.md for more info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just from a cursory look, doesn't this remove qbittorrent-nox
completely, as the PR currently stands?
You don't need to duplicate most code in
As for the apple-sdk version, I've asked in the matrix #macos:nixos.org:
I think the reason for that is the deployment target, if new apple SDK is used without specifying |
9822d63
to
8b711f6
Compare
|
qtWrapperArgs+=("''${gappsWrapperArgs[@]}") | ||
''; | ||
|
||
passthru.updateScript = nix-update-script { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passthru.updateScript = nix-update-script { }; | |
passthru.updateScript = nix-update-script { extraArgs = [ "--version-regex=release-(.*)" ]; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run nix-shell maintainers/scripts/update.nix --argstr package qbittorrent
to test.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.