Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blendfarm: update to net8, apply upstream fixes #359357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gador
Copy link
Member

@gador gador commented Nov 26, 2024

Due to EOL of net6.0 in #358533 blendfarm needs an update.

Upstream hasn't released any commits in the past 10 month, so this also includes a few patches by @lyze237 (thanks!)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Comment on lines 59 to 70
(fetchpatch {
url = "https://github.com/LogicReinc/LogicReinc.BlendFarm/commit/aecfb0a69f9e418158d4a09ec955e0c3f4d8f062.patch?full_index=1";
hash = "sha256-GaIED/TuEa2BYNNfy+/auvLzj7J7HUo2QvUq+pYJPMc=";
})
(fetchpatch {
url = "https://github.com/LogicReinc/LogicReinc.BlendFarm/commit/6276136de0fc567d3a2cc2ecff6effc27688d1a4.patch?full_index=1";
hash = "sha256-F4XW79fAMmdmDpUC0Ktt1YRpzUuMcRQp+48ryZFkSi4=";
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the patch instead, as noted in https://github.com/NixOS/nixpkgs/tree/master/pkgs#patches. Please also write in comment what they do and tracking link.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants