Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luarocks-bootstrap: cmake and zip should be propagatedNativeBuildInputs #359822

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

luarocks-bootstrap: cmake and zip should be propagatedNativeBuildInputs #359822

wants to merge 2 commits into from
+4 −4

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 28, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92
Copy link
Member Author

Mic92 commented Nov 28, 2024

Probably should go into staging...

@ofborg ofborg bot requested review from 7c6f434c and teto November 29, 2024 03:05
7c6f434c
7c6f434c approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But yeah, maybe to staging

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 29, 2024
@teto
Copy link
Member

teto commented Nov 29, 2024 •
edited
Loading

I dont quite get the difference propagatedNativeBuildInputs wont be automatically propagated but I amgined the native in nativeBuildInputs referenced the machine which built the package while this will need to run on target machine in a cross-build context (I have crosscompiled only once so I may be completely out of base).

EDIT: and yeah staging

@Mic92 Mic92 changed the title luarocks-bootstrap: cmake and zip should be nativeBuildInputs luarocks-bootstrap: cmake and zip should be propagatedNativeBuildInputs Nov 29, 2024
@Mic92
Copy link
Member Author

Mic92 commented Nov 29, 2024 •
edited
Loading

@teto the issue just now is that cmake is build for arm64 when cross compiling from an x86 machine. But I am also wondering why does this need to be a propagating build input? If a build system is required for an ecosystem than either a builder or a build hook should be used. Propagating pulls in cmake in places where they are not required. This is different from python libraries.

@Mic92
luarocks-bootstrap: cmake and zip should be nativeBuildInputs
e4bb54b
@Mic92
neovim: disable ruby by default
7b60fc7 
Looking at the ecosystem, I don't see many ruby plugins that would
justify having ruby enabled by default.
@Mic92 Mic92 changed the base branch from master to staging November 29, 2024 10:08
mrcjkb
mrcjkb reviewed Nov 29, 2024
View reviewed changes
pkgs/development/tools/misc/luarocks/luarocks-nix.nix
@@ -16,7 +16,7 @@ luarocks_bootstrap.overrideAttrs (old: {
hash = "sha256-hsjv+jlLsoIDM4gB/0mFeoVu1YZ1I9ELDALLTEnlCF0=";
};

propagatedBuildInputs = old.propagatedBuildInputs ++ [
propagatedNativeBuildInputs = old.propagatedNativeBuildInputs ++ [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: are you sure file and nurl should be propagatedNativeBuildInputs too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcjkb mrcjkb mrcjkb left review comments

@7c6f434c 7c6f434c 7c6f434c approved these changes

@teto teto Awaiting requested review from teto

@figsoda figsoda Awaiting requested review from figsoda

@GaetanLepage GaetanLepage Awaiting requested review from GaetanLepage

@khaneliman khaneliman Awaiting requested review from khaneliman

@manveru manveru Awaiting requested review from manveru

@PerchunPak PerchunPak Awaiting requested review from PerchunPak

@rvolosatovs rvolosatovs Awaiting requested review from rvolosatovs

Assignees
No one assigned
Labels
6.topic: lua 6.topic: vim 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mic92 @teto @7c6f434c @mrcjkb @wegank