appimageTools: use version #359930
Open
appimageTools: use version #359930
+25
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stunkymonkey
changed the title
Stunkymonkey
changed the title
Stunkymonkey
commented
Nov 28, 2024
| extract = args@{ name ? "${args.pname}-${args.version}", postExtract ? "", src, ... }: pkgs.runCommand "${name}-extracted" { | ||
| extract = args@{ pname, version , postExtract ? "", src, ... }: pkgs.runCommand "${pname}-${version}-extracted" { |
There was a problem hiding this comment.
is this fine to do? not sure
There was a problem hiding this comment.
Maybe we should abort if name is passed with an appropriate error?
There was a problem hiding this comment.
good idea. please look at it again.
Stunkymonkey
force-pushed
the
appimage-fhsenv-version
branch
from
db3d787
to
32100f3
Compare
Stunkymonkey
force-pushed
the
appimage-fhsenv-version
branch
from
32100f3
to
572a064
Compare
Pandapip1
approved these changes
Nov 29, 2024
| inherit name; | ||
| exec = name; | ||
| name = pname; | ||
| exec = pname; |
There was a problem hiding this comment.
Not blocking, but this feels wrong.
Pandapip1
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #336576 and #103997
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.