Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf: 28.3 -> 29.0 #359933

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Nov 28, 2024

Things done

Changelog: https://github.com/protocolbuffers/protobuf/releases/v29.0

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

@ofborg build protobuf protobuf.tests

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Nov 28, 2024

@ofborg build python311Packages.protobuf python312Packages.protobuf

@SuperSandro2000
Copy link
Member

@ofborg build mitmproxy

@GaetanLepage
Copy link
Contributor Author

Recap:

  • protobuf.tests build on all platforms 🎉
  • mitmproxy builds on linux but cannot be tested on darwin (broken rustc)
  • python312Packages.jaxlib builds fine on x86_64-linux (python312Packages.jax fails for unrelated reasons)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants