Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Confusion on Y_df and Y_fitted_df inputs for residuals based reconciliation. #162

Open
kdgutier opened this issue Jan 17, 2023 · 1 comment
Assignees
Labels

Comments

@kdgutier
Copy link
Collaborator

The core.reconcile's method Y_df Input names is a bit misleading.

As it is suggesting the possibility of only feeding the models Y_train rather than [Y_fitted, Y_train] that residual based methods use.

It would be convenient that we change the name in future release to avoid confusions.
This is also convenient to match StatsForecast's Y_fitted_df output.

@kdgutier kdgutier changed the title [DOC] Confusion on Y_df and Y_fitted_df inputs for residuals based methods. [DOC] Confusion on Y_df and Y_fitted_df inputs for residuals based reconciliation. Jan 17, 2023
@elephaint
Copy link
Contributor

The problem with renaming it to Y_fitted_df is that there are methods that only need Y_df, or only need a portion of forecast values.

See also #290.

Need to think about this.

@elephaint elephaint self-assigned this Nov 14, 2024
@elephaint elephaint added the fix label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants