Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change reconcile input name from S to S_df #90

Open
kdgutier opened this issue Oct 24, 2022 · 1 comment
Open

Change reconcile input name from S to S_df #90

kdgutier opened this issue Oct 24, 2022 · 1 comment
Assignees
@elephaint
Labels
fix

Comments

@kdgutier
Copy link
Collaborator

In the method core.HierarchicalForecast.reconcile
I suggest we change the name of the S dataframe in to S_df

  • It homogeneizes inputs across libraries.
  • It makes a distinction between method's internal matrix S.
  • Suffix _df helps our user's intuition on the type of input expected.
@cchallu cchallu removed the refactor label Jun 6, 2023
@elephaint
Copy link
Contributor

Agree - with the note that there will be a separate S for temporal aggregation, so that needs to be included in the naming too.

@elephaint elephaint self-assigned this Nov 14, 2024
@elephaint elephaint added the fix label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elephaint elephaint

Labels
fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mergenthaler @kdgutier @cchallu @elephaint