Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rspec-retry not compatible with RSpec 3.3 #25

Closed
JonRowe opened this issue Jun 18, 2015 · 7 comments
Closed

rspec-retry not compatible with RSpec 3.3 #25

JonRowe opened this issue Jun 18, 2015 · 7 comments

Comments

@JonRowe
Copy link
Contributor

JonRowe commented Jun 18, 2015

In RSpec 3.3 we modified our private api for storing memoized variables (lets and subject), the monkey patch you're using is now incompatible see rspec/rspec-core#1999

@myronmarston
Copy link

In general, we prefer if extensions limit themselves to our public APIs, as that prevents this kind of issue. What kind of public APIs would you want to no longer have to monkey patch RSpec?

@galulex
Copy link

galulex commented Jun 22, 2015

@JonRowe
Copy link
Contributor Author

JonRowe commented Jun 22, 2015

We're aware of what you currently (incorrectly) do to override our private APIs, I feel you would to better to retry examples without keeping existing instances around...

@karlingen
Copy link

👍

@fabn
Copy link

fabn commented Jul 7, 2015

Works like a charm, @y310 can you merge this and release? Thanks

@michaelglass
Copy link
Contributor

@JonRowe suggestion for where to wrap tests for retries?

@michaelglass
Copy link
Contributor

closing for #35 now that 0.4.1 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants