-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rspec-retry not compatible with RSpec 3.3 #25
Comments
In general, we prefer if extensions limit themselves to our public APIs, as that prevents this kind of issue. What kind of public APIs would you want to no longer have to monkey patch RSpec? |
We're aware of what you currently (incorrectly) do to override our private APIs, I feel you would to better to retry examples without keeping existing instances around... |
👍 |
Works like a charm, @y310 can you merge this and release? Thanks |
@JonRowe suggestion for where to wrap tests for retries? |
closing for #35 now that 0.4.1 is released |
In RSpec 3.3 we modified our private api for storing memoized variables (lets and subject), the monkey patch you're using is now incompatible see rspec/rspec-core#1999
The text was updated successfully, but these errors were encountered: