Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI still detects RC 1 even though rspec-retry ultimately succeeded #61

Open
aguynamedben opened this issue Sep 15, 2016 · 8 comments

Comments

@aguynamedben
Copy link

I'm using CircleCI, and my spec/support/rspec_retry.rb is:

# Deal with intermittent Selenium timeouts
# From: https://github.com/jnicklas/capybara/issues/1305#issuecomment-112535264

RSpec.configure do |config|
  # show retry status in spec process
  config.verbose_retry = true

  # Try twice (retry once)
  config.default_retry_count = 3

  # Only retry when Selenium raises Net::ReadTimeout
  config.exceptions_to_retry = [Net::ReadTimeout]
end

Sometimes I still get the Net::ReadTimeout, rspec-retry does it's job and the test passes, but RSpec still gives return code 1, which make the build fail.

rspec-retry

Any thoughts on how to configure rspec-retry, RSpec, and/or CircleCI together so that when rspec-retry succeeds I still get RC 0?

Thanks for the work you do on this gem.

@michaelglass
Copy link
Contributor

Can you share a minimal test case where this happens?

@yangez
Copy link

yangez commented Dec 15, 2016

This also happens to me with Codeship:

config.verbose_retry = true
config.default_retry_count = 2
config.exceptions_to_retry = [Net::ReadTimeout]

Any test that raises Net::ReadTimeout the first time but passes on the retry will still fail the codeship build.

@prathamesh-sonpatki
Copy link

Running into similae issue. @aguynamedben @yangez Were you able to solve this?

@comictvn
Copy link

comictvn commented May 4, 2017

any guys have fixed this issue ?

@yangez
Copy link

yangez commented May 8, 2017

Never resolved this - we had to stop using the gem.

@michaelglass
Copy link
Contributor

can you give your rspec-core version?

@choosen
Copy link

choosen commented Jan 3, 2018

Try to update webmock.

Is it possible to precompile assets at Circle before suite ?

@aguynamedben
Copy link
Author

I don't recall ever figuring out how to fix this, and I no longer have access to the project where it was happening. I think we may have had to stop using the gem as well. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants