Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micro-eth-signer issue when deploying local accounts #5967

Open
3 tasks
kanej opened this issue Nov 21, 2024 · 0 comments
Open
3 tasks

micro-eth-signer issue when deploying local accounts #5967

kanej opened this issue Nov 21, 2024 · 0 comments
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task

Comments

@kanej
Copy link
Member

kanej commented Nov 21, 2024

There was an issue with micro-eth-signer that has been fixed here: https://github.com/paulmillr/micro-eth-signer/releases/tag/0.12.2

Specifically it didn't allow a zero address when deploying a contract. Even with the fix micro-eth-signer, it doesn't support sending a transaction to the null address without data. As this is likely a user error we should throw in that situation.

TODO

  • Update to the fixed version of micro-eth-signer
  • Add tests to cover previous bug
  • Add a guard and tests to cover the case where the transaction address is null without data
@kanej kanej added the v-next A Hardhat v3 development task label Nov 21, 2024
@kanej kanej added this to the Private Alpha Follow-up milestone Nov 21, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Nov 21, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Nov 21, 2024
@kanej kanej moved this from Backlog to To-do in Hardhat Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Status: To-do
Development

No branches or pull requests

1 participant