Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update NodeVariant API #1166

Closed
OmarTawfik opened this issue Nov 26, 2024 · 0 comments · Fixed by #1180
Closed

update NodeVariant API #1166

OmarTawfik opened this issue Nov 26, 2024 · 0 comments · Fixed by #1180
Assignees
@mjoerussell

Comments

@OmarTawfik
Copy link
Contributor

OmarTawfik commented Nov 26, 2024 •
edited
Loading

In the jco fork, we need to update the generated APIs for typescript_enum. The APIs are generated using the enum's name as a suffix:

  1. Rename the generated type NodeVariant to NodeType.
  2. Rename the generated property nodeVariant to type.
  3. Generate doc-comments for all the generated APIs, like nodeVariant, asNonterminalNode, isNonterminalNode, etc...
@OmarTawfik OmarTawfik mentioned this issue Nov 26, 2024
Merged
This was referenced Dec 2, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@mjoerussell
Update TS bindings output for variants (#1180)
6a31d1b 
Updates our JCO submodule to include the changes in
NomicFoundation/jco#5. Includes one other change to fully integrate
these changes, which is to change `NodeVariant` to `NodeType` in
`codegen/../cst/index.mts` so that the expected imports align with the
new generated exports.

* [x] Depends on #1169
* [x] Depends on NomicFoundation/jco#5

Closes #1166 
Closes #1171
@github-project-automation github-project-automation bot moved this from ⏳ Todo to ✅ Done in Slang - 2024 H2 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjoerussell mjoerussell

Labels
None yet
Projects
No open projects
Slang - 2024 H2
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update TS bindings output for variants manastech/slang
2 participants
@OmarTawfik @mjoerussell