Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render the response from the API in the feedback box #125

Closed
toddysm opened this issue Mar 4, 2022 · 3 comments · Fixed by #172
Closed

Render the response from the API in the feedback box #125

toddysm opened this issue Mar 4, 2022 · 3 comments · Fixed by #172
Assignees
Milestone

Comments

@toddysm
Copy link
Contributor

toddysm commented Mar 4, 2022

The API response should be specified in the Swagger and returned by the API implemented by #123

One note here: the Swagger may not be correct :)

@CalebMcOlin CalebMcOlin added this to the Sprint 04 milestone Mar 4, 2022
@Hanna-N9 Hanna-N9 self-assigned this Mar 4, 2022
@Hanna-N9 Hanna-N9 changed the title Render the resonse from the API in the feedback box Render the response from the API in the feedback box Mar 7, 2022
@Hanna-N9
Copy link

Hanna-N9 commented Mar 10, 2022

User Story

As a developer,
I want to display the content created by the new API,
So we can see the proper responses returned from the API.


Acceptance Criteria:

  • We want to display responses from the API.

Estimated time to complete:

  • 3 hours

@Hanna-N9
Copy link

Hanna-N9 commented Mar 16, 2022

Activities Documentation

Date Activity Time Spent
2/12/22 Changed two files for the Get request 30 minutes
2/12/22 Tested it but there was issue, as data doesn't show up as expected 10 minutes
2/15/22 Researched iterating through JSON to check if something was wrong with my codes, but my codes were correct. I went ahead to add the other two files with different JSON to upload to the S3 bucket and tested them. It turned out that the fetch method doesn't have access to get data from links of the S3 bucket 1.30 hours
2/15/22 Adjusted my codes and tested if everything was working as expected with the Lambda API 10 minutes
2/17/22 Researched more on the issue of the S3 bucket, I found out that it is because it uses an object instead of an array. I found the solution, but since it is on different files, the solution won't work. 30 minutes
2/17/22 Worked to fix my PR's conflicts. 20 minutes
2/18/22 Created a new feature branch to modify everything again to use Post method to make Steven's URL work. 5 hours
2/19/22 Tried to get the results in the console window and tested the codes. 2 hours

Total time: 10.10 hours (Although late, I checked on Steven's URL and tested it using Post method hence extra hours for second PR.)

@Hanna-N9
Copy link

Hanna-N9 commented Mar 16, 2022

First PR that I can't merged in anymore since it means to revert everything back after the group members merged theirs.

Changes in files:

  • Comment out the Post request without removing it and change the method to Get request in the SubmitBtn.js file to get data from the URL.
  • In the FeedBox.js file, the map method is added to loop through JSON to indicate the data in the analysis box.

Documentation (step-by-step):

image

Second PR to merge in:

Documentation (step-by-step):

  • cd frontend
  • npm start
  • Copy this phrase to the input box:
Generating random paragraphs can be an excellent way for writers to get their creative flow going at the beginning of the day. The writer has no idea what topic the random paragraph will be about when it appears. This forces the writer to use creativity to complete one of three common writing challenges. The writer can use the paragraph as the first one of a short story and build upon it. A second option is to use the random paragraph somewhere in a short story they create. The third option is to have the random paragraph be the ending paragraph in a short story. No matter which of these challenges is undertaken, the writer is forced to use creativity to incorporate the paragraph into their writing.
  • Click the 'Submit' button
  • Wait for the results to display in the feedback box

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment