Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slack] - Requesting No Reviewers on CR spams the Slack #3049

Open
alaneng-neu opened this issue Dec 5, 2024 · 0 comments
Open

[Slack] - Requesting No Reviewers on CR spams the Slack #3049

alaneng-neu opened this issue Dec 5, 2024 · 0 comments
Labels
back-end bug Something isn't working front-end

Comments

@alaneng-neu
Copy link
Contributor

Description

There is a bug where if you try requesting reviewers on FinishLine with no reviewers selected, it will spam the slack. See this video demo.

Acceptance Criteria

The bug is fixed to not spam the slack if you request a review from no one, and also limiting the behavior so that if you do not select reviewers, it just doesn't let you hit the request review button.

Proposed Solution

You will have to look at the backend code for requesting a review on a change request and find anything that may trigger a sending of a slack message multiple times in the case where there are no reviewers. Additionally, you will have to add frontend restriction to the "Request Review" button so that if there are no reviewers selected, it doesn't let you hit/submit the button.

Mocks

No response

@alaneng-neu alaneng-neu added bug Something isn't working back-end front-end labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end bug Something isn't working front-end
Projects
None yet
Development

No branches or pull requests

1 participant