You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a bug where if you try requesting reviewers on FinishLine with no reviewers selected, it will spam the slack. See this video demo.
Acceptance Criteria
The bug is fixed to not spam the slack if you request a review from no one, and also limiting the behavior so that if you do not select reviewers, it just doesn't let you hit the request review button.
Proposed Solution
You will have to look at the backend code for requesting a review on a change request and find anything that may trigger a sending of a slack message multiple times in the case where there are no reviewers. Additionally, you will have to add frontend restriction to the "Request Review" button so that if there are no reviewers selected, it doesn't let you hit/submit the button.
Mocks
No response
The text was updated successfully, but these errors were encountered:
Description
There is a bug where if you try requesting reviewers on FinishLine with no reviewers selected, it will spam the slack. See this video demo.
Acceptance Criteria
The bug is fixed to not spam the slack if you request a review from no one, and also limiting the behavior so that if you do not select reviewers, it just doesn't let you hit the request review button.
Proposed Solution
You will have to look at the backend code for requesting a review on a change request and find anything that may trigger a sending of a slack message multiple times in the case where there are no reviewers. Additionally, you will have to add frontend restriction to the "Request Review" button so that if there are no reviewers selected, it doesn't let you hit/submit the button.
Mocks
No response
The text was updated successfully, but these errors were encountered: